search

DTUWindEnergy / PyWake

Mirror of https://gitlab.windenergy.dtu.dk/TOPFARM/PyWake
MIT License
72 stars 26 forks source link

Added missing tilt needed by JimenezWakeDeflection in example notebook #11

Closed kristianQh closed 7 months ago

kristianQh commented 7 months ago

Hi, I randomly came across your simulation tool and noticed a ValueError in one of the example notebook in the documentation. While I'm not familiar with wind farms, I investigated the issue and found that the Jimez wake deflection model in the notebook seemed to be missing a required tilt parameter.

After adding a tilt integer slider, the example notebook runs without errors and seem to deflect based on the specified angle.

The changes do not affect any other parts of the documentation or codebase, it is an isolated update to the notebook to ensure it does not resolve in an error on your documentation page.

madsmpedersen commented 7 months ago

Thank you very much for finding and fixing the error. I have merged it here: https://gitlab.windenergy.dtu.dk/TOPFARM/PyWake/-/merge_requests/556