[WIP] Contacts improvements

DTel-HQ / dtel

Telephone roleplay bot on Discord

https://dtel.austinhuang.me

Other

112 stars 35 forks source link

[WIP] Contacts improvements #263

Closed Rexogamer closed 3 years ago

Rexogamer commented 4 years ago

WIP PR, opening for initial review/CI

Todo:

todo: let the user actually rerun it (more methodsssss)
warn about length in other places
general cleanup

Rexogamer commented 4 years ago

latest codacy error confuses me tbh

turret-dev commented 4 years ago

latest codacy is probably because it starts with an e so codacy thinks its a number in scientific expression and codacy doesnt see a + so it throws that error

Mitchell3514 commented 4 years ago

No, codacy knows that it's a numeric literal

Mitchell3514 commented 4 years ago

Hex values should still be in capital letters though

turret-dev commented 4 years ago

why is hound approving the post if "3 violations found" is its status

Mitchell3514 commented 4 years ago

why is hound approving the post if "3 violations found" is its status

Guess Hound knows they're wrong

Rexogamer commented 4 years ago

Marking as ready for review to deal with merge conflicts

Rexogamer commented 4 years ago

No conflicts :eyes: