DTel-HQ / dtel

Telephone roleplay bot on Discord
https://dtel.austinhuang.me
Other
112 stars 35 forks source link

refactor: unify similar embeds #289

Closed Rexogamer closed 3 years ago

Rexogamer commented 3 years ago

This brings several embeds into embeds.js.

Resolves #287

Mitchell3514 commented 3 years ago

Can you fix Codacy

Rexogamer commented 3 years ago

I'm not sure how short of importing the embeds file every time. I've exported the embeds the same way as we export the config and aliases...

Mitchell3514 commented 3 years ago

I'm not sure how short of importing the embeds file every time. I've exported the embeds the same way as we export the config and aliases...

Seeing as Codacy doesn't see the other imports as an issue, it probably reads the .eslintrc file for defined globals.

SunburntRock89 commented 3 years ago

why don't we be normal and just not use globals

lgtm-com[bot] commented 3 years ago

This pull request introduces 4 alerts and fixes 2 when merging bb3656ab6f9ccf396a1f221d45fb625622fb4de6 into a16fc8240bd555a04f0d4a2e18cb2667777837c1 - view on LGTM.com

new alerts:

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 4 alerts and fixes 2 when merging b074d258186d1ae764476a566de7a7b96af2f5fe into a16fc8240bd555a04f0d4a2e18cb2667777837c1 - view on LGTM.com

new alerts:

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request fixes 2 alerts when merging cb79c83527e8b36454d00ebf4f49938061afef1b into a16fc8240bd555a04f0d4a2e18cb2667777837c1 - view on LGTM.com

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request fixes 2 alerts when merging 3f8f84db30a48d3423e5e7d6461721d150434c21 into 7d30a37d5a6bdadee2a921c38af6b87723ca1da8 - view on LGTM.com

fixed alerts: