Use enum for vendor ID - Githubissues

DTolm / VkFFT

Vulkan/CUDA/HIP/OpenCL/Level Zero/Metal Fast Fourier Transform library

MIT License

1.52k stars 91 forks source link

Use enum for vendor ID #166

Open DejvBayer opened 6 months ago

DejvBayer commented 6 months ago

This pull request introduces VkFFTVendor enum datatype for vendor id instead of using magic values.

DTolm commented 6 months ago

Hello,

Thank you for the change, it will also make the code more clear. It missed the 0x1027f00 Apple vendor ID definition and I am not sure yet whether the casting of vendor IDs returned by different APIs to the enum will trigger any warnings (in Vulkan I believe it to be an unsigned integer).

Best regards, Dmitrii

DejvBayer commented 6 months ago

Hi,

I have fixed the casts from different types and added VKFFT_VENDOR_APPLE to the enum. I am sorry, I overlooked it completely.

Best regards, David