Open DejvBayer opened 3 weeks ago
Hello,
This is a good idea, I have added it (to all user buffers except tempBuffer, this one is usually allocated and managed by VkFFT). However, it complicates things a bit. For example, cuLaunchKernel expects void as an argument (https://docs.nvidia.com/cuda/cuda-driver-api/group__CUDA__EXEC.html#group__CUDA__EXEC_1gb8f3dc3031b40da29d5f9a7139e52e15), so it will just move casting to void inside VkFFT.
Best regards, Dmitrii
I know about it, however I believe this is a better solution. Thanks for the change!
Hi,
I have noticed that most of the parameters passed to VkFFT are passed by address, for example:
The problem is that the
buffer
member is defined asvoid**
and if I have a constant array of pointers, the compiler emits warning that I castvoid* const*
tovoid**
. I would suggest changing allType**
members toType* const*
unless the pointers is modified by VkFFT. It is the same story forVkFFTLaunchParams
. Example:One more idea: for input buffers it may be convinient to use
const void* const*
to indicate that the input data are never overwritten (only for CUDA, HIP and LevelZero).Thanks a lot!
David