search

DTolm / VkFFT

Vulkan/CUDA/HIP/OpenCL/Level Zero/Metal Fast Fourier Transform library
MIT License
1.52k stars 91 forks source link

Several warnings about unused variables and redundant typedefs in latest commit #82

Closed azonenberg closed 2 years ago

azonenberg commented 2 years ago 
[ 84%] Building CXX object lib/scopeprotocols/CMakeFiles/scopeprotocols.dir/scopeprotocols.cpp.o
In file included from /ceph/fast/home/azonenberg/code/scopehal-apps/lib/scopehal/VulkanFFTPlan.h:46,
                 from /ceph/fast/home/azonenberg/code/scopehal-apps/lib/scopeprotocols/FFTFilter.h:44,
                 from /ceph/fast/home/azonenberg/code/scopehal-apps/lib/scopeprotocols/scopeprotocols.h:100,
                 from /ceph/fast/home/azonenberg/code/scopehal-apps/lib/scopeprotocols/TachometerFilter.cpp:30:
/ceph/fast/home/azonenberg/code/scopehal-apps/lib/scopehal/../VkFFT/vkFFT/vkFFT.h:411:1: warning: ‘typedef’ was ignored in this declaration
  411 | typedef struct VkFFTRaderContainer {
      | ^~~~~~~
In file included from /ceph/fast/home/azonenberg/code/scopehal-apps/lib/scopehal/VulkanFFTPlan.h:46,
                 from /ceph/fast/home/azonenberg/code/scopehal-apps/lib/scopeprotocols/FFTFilter.h:44,
                 from /ceph/fast/home/azonenberg/code/scopehal-apps/lib/scopeprotocols/TDRStepDeEmbedFilter.cpp:32:
/ceph/fast/home/azonenberg/code/scopehal-apps/lib/scopehal/../VkFFT/vkFFT/vkFFT.h: In function ‘VkFFTResult VkFFTScheduler(VkFFTApplication*, VkFFTPlan*, uint64_t, uint64_t)’:
/ceph/fast/home/azonenberg/code/scopehal-apps/lib/scopehal/../VkFFT/vkFFT/vkFFT.h:28938:12: warning: variable ‘useRaderFFT’ set but not used [-Wunused-but-set-variable]
28938 |   uint64_t useRaderFFT = 0;
      |            ^~~~~~~~~~~
In file included from /ceph/fast/home/azonenberg/code/scopehal-apps/lib/scopehal/VulkanFFTPlan.h:46,
                 from /ceph/fast/home/azonenberg/code/scopehal-apps/lib/scopeprotocols/FFTFilter.h:44,
                 from /ceph/fast/home/azonenberg/code/scopehal-apps/lib/scopeprotocols/scopeprotocols.h:100,
                 from /ceph/fast/home/azonenberg/code/scopehal-apps/lib/scopeprotocols/TappedDelayLineFilter.cpp:30:
/ceph/fast/home/azonenberg/code/scopehal-apps/lib/scopehal/../VkFFT/vkFFT/vkFFT.h: In function ‘VkFFTResult VkFFTScheduler(VkFFTApplication*, VkFFTPlan*, uint64_t, uint64_t)’:
/ceph/fast/home/azonenberg/code/scopehal-apps/lib/scopehal/../VkFFT/vkFFT/vkFFT.h:28938:12: warning: variable ‘useRaderFFT’ set but not used [-Wunused-but-set-variable]
28938 |   uint64_t useRaderFFT = 0;
      |            ^~~~~~~~~~~
In file included from /ceph/fast/home/azonenberg/code/scopehal-apps/lib/scopehal/VulkanFFTPlan.h:46,
                 from /ceph/fast/home/azonenberg/code/scopehal-apps/lib/scopeprotocols/FFTFilter.h:44,
                 from /ceph/fast/home/azonenberg/code/scopehal-apps/lib/scopeprotocols/SpectrogramFilter.cpp:37:
/ceph/fast/home/azonenberg/code/scopehal-apps/lib/scopehal/../VkFFT/vkFFT/vkFFT.h: In function ‘VkFFTResult VkFFTScheduler(VkFFTApplication*, VkFFTPlan*, uint64_t, uint64_t)’:
/ceph/fast/home/azonenberg/code/scopehal-apps/lib/scopehal/../VkFFT/vkFFT/vkFFT.h:28938:12: warning: variable ‘useRaderFFT’ set but not used [-Wunused-but-set-variable]
28938 |   uint64_t useRaderFFT = 0;
      |            ^~~~~~~~~~~
DTolm commented 2 years ago

Hello,

I have tried to fix some of the warnings, the last commit should work better.

Best regards, Dmitrii

azonenberg commented 2 years ago

Thanks, seems to be fixed.