search

DUNE-DAQ / appfwk

DUNE DAQ Application Framework Repository (implementations that use interfaces in app-framework-base)
5 stars 5 forks source link

`Application_test` unit test fails #306

Closed jcfreeman2 closed 2 weeks ago

jcfreeman2 commented 2 weeks ago

Specifically, here's the message I get:

Start of unit test suite Application_test
Running 9 test cases...
Entering test module "Application_test"
/home/nfs/jcfree/NFD_DEV_241112_A9/sourcecode/appfwk/unittest/Application_test.cxx(22): Entering test suite "Application_test"
/home/nfs/jcfree/NFD_DEV_241112_A9/sourcecode/appfwk/unittest/Application_test.cxx(35): Entering test case "Constructor"
2024-Nov-12 14:57:47,319 LOG [dunedaq::appfwk::ConfigurationManager::ConfigurationManager(...) at /home/nfs/jcfree/NFD_DEV_241112_A9/sourcecode/appfwk/src/ConfigurationManager.cpp:19] configSpec <oksconflibs:test/config/appSession.data.xml> session name partition_name application name TestApp
2024-Nov-12 14:57:47,431 LOG [dunedaq::appfwk::ConfigurationManager::ConfigurationManager(...) at /home/nfs/jcfree/NFD_DEV_241112_A9/sourcecode/appfwk/src/ConfigurationManager.cpp:31] Failed to get session
eflumerf commented 2 weeks ago

OK. There are a few issues here to unpack. https://github.com/DUNE-DAQ/appfwk/blob/develop/src/ConfigurationManager.cpp#L32 would be my candidate for the most egregious; as it is the reason this was missed for so long.

Updating Application_test to use "test-session" instead of "partition_name", I get a seg-fault possibly due to the multiple instantiations of the Application class in the unit test.

jcfreeman2 commented 2 weeks ago

Closing as this has been fixed thanks to feature branches from Eric both for this package and opmonlib in the last day.