DUNE-DAQ / daq-buildtools

Make life for developers easier through a collection of CMake functions and scripts
0 stars 1 forks source link

Feature/dingpf individual unittest log #178

Closed dingp closed 2 years ago

dingp commented 2 years ago

This PR changes dbt-build.py, so that:

jcfreeman2 commented 2 years ago

Ran some unit testing and linting and the saved results look good

jcfreeman2 commented 2 years ago

One quick thing: it may be worth considering consistency between the filenames for individual unit tests vs. the summary. E.g., right now in a given subdirectory we have:

dfmodules_DataFlowOrchestrator_test_unittest_Fri_Mar_11_17_18_24_CST_2022.log
unit_test_summary.log

so it's worth considering whether both, or neither, of the filenames should bear the timestamp.

dingp commented 2 years ago

the timestamp is already in the directory name, so I consider removing it from the name of individual test logs.

dingp commented 2 years ago

similarly for the linting log, the datestring is included in the dir name, so removing it from the log file's name.