search

DUNE-DAQ / daq-release

Scripts and configuration files for the DUNE DAQ release
https://dune-daq-sw.readthedocs.io/en/latest/packages/daq-release/
2 stars 0 forks source link

jsonschema 4.17.3 fails with pytest #328

Closed jcfreeman2 closed 9 months ago

jcfreeman2 commented 9 months ago

This Issue is spun off of https://github.com/DUNE-DAQ/daq-cmake/issues/104 , which Kurt filed and which describes a phenomenon introduced when the jsonschema version was bumped from 3.2.0 to 4.17.3 during the fddaq-v4.2.0 release process.

Basically, the line from jsonschema.exceptions import ValidationError, found in moo's jsonschema.py file, breaks when (1) we run a test from daqsystemtest out of cvmfs (i.e., pytest -s /cvmfs/...) and (2) we use jsonschema 4.17.3 instead of 3.2.0

Concerning (2), the failure occurs in the load_schema function defined in jsonschema's _utils.py file, which got rewritten between 3.2.0 and 4.17.3. Why the failure is occurring is not yet clear, however. The line from jsonschema.exceptions import ValidationError works fine even with 4.17.3 as long the code isn't passed to pytest.

jcfreeman2 commented 9 months ago

Closing this as Alessandro points out we'll be dropping jsonschema soon thanks to the switchover to OKS anyway.