search

DUNE-DAQ / daq-release

Scripts and configuration files for the DUNE DAQ release
https://dune-daq-sw.readthedocs.io/en/latest/packages/daq-release/
2 stars 0 forks source link

Amogan issue345 more integtests #348

Closed andrewmogan closed 9 months ago

andrewmogan commented 9 months ago

This PR is a first step toward addressing Issue #345. More tests may be added in the future, but some of them cause strange timeout errors when run in the Github runner (as opposed to, say, an np04 machine). I confirmed that this combination of tests succeeds in the Github runner.

jcfreeman2 commented 9 months ago

Overall looks good. Two things which should be addressed before we merge: 1) The name minimal_system_integration is still used for the name of the Workflow, but this should be updated to reflect the greater generality of the testing now. Also as I write this, it occurs to me that we should drop the Workflow from theNightly Integration Test Workflow. 2) Currently only the results of the final pytest call makes it into the dashboard (e.g., if I scroll down to the bottom of https://github.com/DUNE-DAQ/daq-release/actions/runs/7916017152, it says 3 tests passed in 40 seconds, which is pretty clearly the result of the small_footprint_quick_test.py). This should be changed so that all tests are included, and in fact I wonder if we could break things down so the dashboard could tell us which pytest call resulted in failure - e.g., if long_window_readout_test.py causes a failure, that we could figure that out just from the dashboard.

jcfreeman2 commented 9 months ago

The output from the current head of the feature branch looks good (https://github.com/DUNE-DAQ/daq-release/actions/runs/7922014656). Approved.