search

DUNE-DAQ / daq-release

Scripts and configuration files for the DUNE DAQ release
https://dune-daq-sw.readthedocs.io/en/latest/packages/daq-release/
2 stars 0 forks source link

If a test fails in `nightly-integtest.yml`, the remaining tests should still run #351

Closed jcfreeman2 closed 5 months ago

jcfreeman2 commented 6 months ago

The problem we want to solve is evidenced, e.g., here: https://github.com/DUNE-DAQ/daq-release/actions/runs/8046225513 where you see that as soon as our second test, fake_data_producer_test.py, failed, the remaining long_window_readout_test.py and small_footprint_quick_test.py. To maximize information though, we should modify this Workflow so if one test fails (i.e., returns nonzero), the remaining tests still run, while still having the overall Workflow indicate a failure. In other words, mask the nonzero return from an individual test, but have the Workflow return nonzero if there's such a return.

jcfreeman2 commented 5 months ago

Good news and bad news. If all four tests pass, the output looks good (https://github.com/DUNE-DAQ/daq-release/actions/runs/8284518730). However, if I deliberately use the amogan/break_fake_data_test branch of daqsystemtest, no test output makes it to the GitHub Workflow page (https://github.com/DUNE-DAQ/daq-release/actions/runs/8284359473).

jcfreeman2 commented 5 months ago

Closing with successful merge of PR #354