DUNE-DAQ / daq-release

Scripts and configuration files for the DUNE DAQ release
https://dune-daq-sw.readthedocs.io/en/latest/packages/daq-release/
2 stars 0 forks source link

JCF: have build-release.sh fail immediately with a nonzero return val… #360

Closed jcfreeman2 closed 4 months ago

jcfreeman2 commented 4 months ago

…ue if pip installation fails

To test this, fork off a (very temporary) branch from this feature branch, sabotage a version number for a Python package for a detector's release.yaml file (e.g. can just recreate the issue with the second candidate build for fddaq-v4.4.0), then run the relevant build workflow on your forked branch.

If the Workflow fails because of the failed pip installation, the test succeeded, and you can merge in this PR as well as delete the branch which you forked off.

andrewmogan commented 4 months ago

Recreating the issue from fddaq-v4.4.0-rc2 resulted in an explicit failure with this message:

  WARNING: Did not find branch or tag 'vv5.2.2', assuming revision or ref.
  Running command git checkout -q vv5.2.2
  error: pathspec 'vv5.2.2' did not match any file(s) known to git
  error: subprocess-exited-with-error

  × git checkout -q vv5.2.2 did not run successfully.
  │ exit code: 1
  ╰─> See above for output.

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error
× git checkout -q vv5.2.2 did not run successfully.
│ exit code: 1
╰─> See above for output.
note: This error originates from a subprocess, and is likely not a problem with pip.
Notice:  A new release of pip is available: 23.0 -> 24.0
Notice:  To update, run: python -m pip install --upgrade pip
Error: Process completed with exit code 11.

So the test was successful.