DUNE-DAQ / daq-release

Scripts and configuration files for the DUNE DAQ release
https://dune-daq-sw.readthedocs.io/en/latest/packages/daq-release/
2 stars 0 forks source link

Fix name of branch_name variable #363

Closed andrewmogan closed 7 months ago

andrewmogan commented 7 months ago

Responding to issue #362, looks like I just forgot to name branch to branch_name. I've tested locally that supplying an overwrite_branch to DAQRelease works as expected, e.g., I can checkout production/v4 instead of develop and generate the repos correctly.

Also, I realized there's no obvious reason to set a default value for branch_name, so it's now a required argument.

jcfreeman2 commented 7 months ago

Looks good.