search

DUNE-DAQ / daq-release

Scripts and configuration files for the DUNE DAQ release
https://dune-daq-sw.readthedocs.io/en/latest/packages/daq-release/
2 stars 0 forks source link

AJM: Check release tags exist when generating repos #367

Closed andrewmogan closed 3 months ago

andrewmogan commented 3 months ago

In response to Issue #366, this PR adds a couple of explicit checks that a tag listed in a release yaml exists and fails loudly if it does not. I added two such checks, one to make-release-repo.py's get_commit_hash function, and one in checkout-daq-package.py's checkout_tag function. I've tested that these work by changing an arbitrary tag in, for example, the fddaq-v4.4.0 release yaml to something that doesn't exist. I also checked that things still work normally when generating repos based on the develop branch, like during a nightly build.

jcfreeman2 commented 3 months ago

I've confirmed that the build action crashes out if a nonexistent tag is requested (https://github.com/DUNE-DAQ/daq-release/actions/runs/8898552039/job/24435931956); also at the command line that checkout-daq-package.py returns nonzero if there's a nonexistent tag. Approved.