Extensively rename classes, etc., in OKS-related code

DUNE-DAQ / daq-release

Scripts and configuration files for the DUNE DAQ release

https://dune-daq-sw.readthedocs.io/en/latest/packages/daq-release/

2 stars 0 forks source link

Extensively rename classes, etc., in OKS-related code #376

Closed jcfreeman2 closed 1 month ago

jcfreeman2 commented 2 months ago

...as mentioned at this morning's OKS meeting. The name changes are detailed here: https://docs.google.com/spreadsheets/d/1k3ScIDQJTLHPjsMgsIPm8tGYSZa6HEm5f1xvsl8M5vU/edit?gid=0#gid=0

jcfreeman2 commented 2 months ago

A first round of merges was performed on Friday. Saturday on Slack Alessandro pointed out that the following changes were still needed:

DataReceiverModule needs to be changed to DataReaderModule
DPDKReader to DPDKReaderModule (I believe he's already done this)
FDFakeCardReader to FDFakeCardReaderModule

jcfreeman2 commented 2 months ago

Further renames for today:

WIBConfigurator -> WIBModule
DataReceiverModule -> DataReaderModule, DataReceiverConf -> DataReaderConf

For the latter case, changes that made it onto the develop branch of appmodel overnight meant that DataReceiverModule persisted despite this morning's merge of johnfreeman/daq-release_issue376_renames_for_v5_pt2

jcfreeman2 commented 2 months ago

Closing this; three waves of name changes have been successfully performed and further changes are addressed in later issues (e.g., #379)

jcfreeman2 commented 1 month ago

Complete; changes going in to fddaq-v5.1.0