search

DUNE-DAQ / datahandlinglibs

An enhanced replacement of readoutlibs + readoutmodules
0 stars 0 forks source link

Fix lower bound logic #27

Closed wesketchum closed 1 month ago

wesketchum commented 1 month ago

Fixes #24 .

Also adds some minor changes to better support new unit tests (currently in fdreadoutlibs) that are rather templated. Some of these likely need to be discussed, which is one reason why I'm starting this off as a draft PR.

The other reason is that there are still changes that will be needed on the ReuqeustHandlers.

This should be ready for full review / testing. Testing should be included with PRs in fdreadoutlibs, trigger, and hsilibs. In a development area, one can get the needed branches like:

 git clone https://github.com/DUNE-DAQ/fdreadoutlibs.git -b feature/wketchum_LowerBoundAndRequestUnitTests
 git clone https://github.com/DUNE-DAQ/datahandlinglibs.git -b feature/wketchum_FixLowerBoundLogic
 git clone https://github.com/DUNE-DAQ/trigger.git -b feature/wketchum_AddTypeAdapterBufferUnitTests
 git clone https://github.com/DUNE-DAQ/hsilibs.git -b feature/wketchum_AddTypeAdapterBufferUnitTests

Running unittests should all pass:

dbt-build --unittest

I am having issues with minimal_system_quicktest running on NP04 servers with the latest nightly (241029), though they don't look to me to be related with any of these changes.

wesketchum commented 1 month ago

(This does have a minor fix that I think resolves #26 too.)

wesketchum commented 1 month ago

OK, @eflumerf and @bieryAtFnal confirm minimal system quick test is passing for them, and so as this is approved otherwise I will merge. (Still working on getting it to work for me, but that's likely another story...)