search

DUNE-DAQ / detdataformats

Decoders for DUNE raw data
2 stars 2 forks source link

MPD Frame implementation #63

Closed jtenavidal closed 1 year ago

jtenavidal commented 1 year ago

NOTE: this is part of a bigger pull request - https://github.com/DUNE-DAQ/lbrulibs/pull/44

This particular pull request, contains the changes required to implement the MPD Frame (include/detdataformats/mpd/MPDFrame.hpp). The data format description is available https://docs.google.com/spreadsheets/d/1b9ohCndIZcYHEPiRDz4TMbaf6CJNlXrEuMnt3XS2BZ8/edit#gid=1694585828. This link is also added in the corresponding MPDFrame.hpp file.

Additional changes are required. A new DetID type is added in DetID.hpp. This change is required in order to configure the MPD frame. There is similar additional changes related to the new DetID definition.

Finally, pybindsrc/mpd.cpp contains the definition of python function from the C++ code. This is related to the python scripts from lbrulibs ( https://github.com/DUNE-DAQ/lbrulibs/pull/44)

eflumerf commented 1 year ago

I opened #68 to address my comment above. Otherwise, things look good.