DUNE-DAQ / drunc

Dune RUN Control (DRUNC) is the run control for the DUNE experiment
1 stars 1 forks source link

`terminate` not available #146

Closed PawelPlesniak closed 3 months ago

PawelPlesniak commented 4 months ago

When running test-session, I found that fsm terminate would not run and it disappears from the available list of FSMtransitions printed after going through the whole FSM cycle. Not sure of source

gcrone commented 4 months ago

Doesn't seem to be there right from the begiining.

           INFO     "unified": You are in control.                                                   shell_utils.py:284
Current FSM status is initial. Available transitions are conf terminate
drunc-unified-shell > fsm terminate
Usage: PROCESS_MANAGER_CONFIGURATION fsm [OPTIONS] COMMAND [ARGUMENTS]...
Try 'PROCESS_MANAGER_CONFIGURATION fsm --help' for help.

Error: Invalid value: Unrecognised FSMcommand.
drunc-unified-shell > describe --command fsm
                        root-controller.test-session (controller) commands                         
┏━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━┳━━━━━━━━━━━━━━━━━━━┓
┃ name ┃ input type                ┃ return type                       ┃ help ┃ Command arguments ┃
┡━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━╇━━━━━━━━━━━━━━━━━━━┩
│ conf │ controller_pb2.FSMCommand │ controller_pb2.FSMCommandResponse │      │                   │
└──────┴───────────────────────────┴───────────────────────────────────┴──────┴───────────────────┘
drunc-unified-shell > 
PawelPlesniak commented 4 months ago

Started addressing with PR#166 This will not include terminate in describe yet.

PawelPlesniak commented 4 months ago

The FSM diagram has been updated. terminate is not an FSM command, it is a process_manager command. Diagram updated: PR#167 boot updated: PR#168