search

DUNE-DAQ / drunc

Dune RUN Control (DRUNC) is the run control for the DUNE experiment
1 stars 1 forks source link

Should not finding the environment setup script be an error? #259

Closed jcfreeman2 closed 1 month ago

jcfreeman2 commented 1 month ago

Basically, if you try, e.g., running drunc-unified-shell after setting up the environment via dbt-setup-release rather than via a work area, you'll get this warning:

           WARNING  "process_manager_driver": RTE was not supplied in the OKS            process_manager_driver.py:107
                    configuration or in the environment, running without it

and then several paragraphs worth of complaints ending in failure. Is there a use case where we'd want to run without an environment script for the processes? If not, this should be an error causing an exit rather than just a warning.

plasorak commented 1 month ago

https://github.com/DUNE-DAQ/drunc/blob/develop/src/drunc/process_manager/process_manager_driver.py#L93C1-L108C1 We can make an exception, yes. To fix the problem here, is DBT_INSTALL_DIR setup by dbt-setup-release?

plasorak commented 1 month ago

This has been fixed here: https://github.com/DUNE-DAQ/drunc/pull/271