search

DUNE-DAQ / drunc

Dune RUN Control (DRUNC) is the run control for the DUNE experiment
1 stars 1 forks source link

Fix message format and acquire a lock to read the actor token #273

Closed plasorak closed 1 month ago

plasorak commented 1 month ago

Attempt to fix https://github.com/DUNE-DAQ/drunc/issues/268 There are 2 problem in that issue:

  1. Why is the ControllerActor not the one in charge of the controller?
  2. The stack itself which is clearly a bug

For 2., its quite simple. For 1. this PR made the assumption that the read of the actor happens while the actor is being changed (take_control), therefore leading to this weird, transient error.

eflumerf commented 1 month ago

Just tested and had the problem happen again. I'm going to try running with debug logging enabled for the controllers...

eflumerf commented 1 month ago

log_eflumerf_minimal_ru-controller.log log_eflumerf_minimal_trg-controller.log log_eflumerf_minimal_df-controller.log log_eflumerf_minimal_root-controller.log

plasorak commented 1 month ago

Fixes: https://github.com/DUNE-DAQ/drunc/issues/276