search

DUNE-DAQ / drunc

Dune RUN Control (DRUNC) is the run control for the DUNE experiment
1 stars 1 forks source link

No stack on failed connectivity service lookup (redo) #275

Closed jcfreeman2 closed 1 month ago

jcfreeman2 commented 1 month ago

This is a PR for a feature branch which perfectly recreates the plasorak/no-stack-on-failed-lookup branch, commit e5d88ede0b752fcada738c6544eee93004d9172a

PR #272 was accidentally merged into develop a little while ago. While I've reverted the change to the head of develop so that as of this writing it's as if PR #272 hadn't been merged into it, git's conception of the merge history is such that we can't simply re-do the PR with the original feature branch, plasorak/no-stack-on-failed-lookup. So what I've done here is create a new feature branch which is an exact copy of plasorak/no-stack-on-failed-lookup, enabling a "do-over".

plasorak commented 1 month ago

To test that PR, one needs to break the applications/controller. This is done in the branch plasorak/break-PR272, which voluntarily introduces a typo for the RTE script. There is just one single simple commit on top of this branch.