search

DUNE-DAQ / dtpcontrols

DUNE Trigger Primitives Control Software
0 stars 1 forks source link

Joealsubash/developcpp #11

Closed joealsubash closed 2 years ago

jimbrooke commented 2 years ago

@joealsubash just a note here that you need to merge develop into your branch to resolve these conflicts

jimbrooke commented 2 years ago

Here's a proposal for how to use the FW config info. The idea here is not to couple the FW config info until we understand it.

  1. implement set methods for number of links, and any similar items that are needed by the software object. These will ultimately be called by the dtpctrllibs::DTPController::configure() - the software setup step.
  2. implement a method which retrieves the FW config from FW. This should not change the SW object state. (I think this is what get_firmware_config_info() does in this PR).
  3. any methods which need to know eg. number of links use the value stored by method 1.
  4. implement a method check_fw_config() which calls method 2 and compares it with values stored by method 1. It can write any mismatches to error log, and return a bool. In future we might want this to throw an error during dtpctrllibs::DTPController::configure() but we can decide that much further down the line.

For this PR, we only need points 1-3. point 4 can come later.