search

DUNE-DAQ / dtpcontrols

DUNE Trigger Primitives Control Software
0 stars 1 forks source link

Jimbrooke/structure #9

Closed jimbrooke closed 2 years ago

jimbrooke commented 2 years ago

This contains the basic structure of C++ classes which represent the firmware. Many classes currently do nothing, but they will ultimately contain the code which controls the firmware.

Changes wrt Joeal's initial PR :

  1. add namespaces
  2. remove unnecessary #includes
  3. remove DTPNode
  4. rename/move test apps
  5. get connections file (dtp_connections.xml) from $DUNEDAQ_SHARE_PATH
  6. add top-level DTPPodNode
  7. add full set of node classes (inc several placeholders)
  8. fix style issues (snake case)
jimbrooke commented 2 years ago

Class structure is there, with a basic test that it works at test/apps/test_nodes.cxx

alessandrothea commented 2 years ago

I suspect that the pipeline failure is due to a broken cmakeConfig in uhallibs. I think I've fixed that and pushed it to develop. If I'm right the failing pipeline will work tomorrow after the nightly has completed

alessandrothea commented 2 years ago

Commit in question https://github.com/DUNE-DAQ/uhallibs/commit/23f006d689ff23cfebfaa24268394ad3ea484dba

jimbrooke commented 2 years ago

thanks @alessandrothea. if that works I think this PR is ready for merging - unless you see any issues. i've fixed the ones you raised above.