clock_frequency is already part of the session configuration, also our clock frequency will hopefully no longer be variable, so this probably be removed as a configurable parameter. At the least we should not duplicate the configuration here
address and partition are unsigned integers, not strings. Also the partition parameter is no longer needed. It should be cleaned up at some point.
rising_edge_mask, falling_edge_mask, and invert_edge_mask are of type u32 but have a string a default
data_source type should be unsigned integer
In the C++ code, FakeHSIGenerator and CTBModule inherit from HSIEventSender, the schema should reflect that
A few comments from an initial look:
device
is already defined in TimingControllerclock_frequency
is already part of the session configuration, also our clock frequency will hopefully no longer be variable, so this probably be removed as a configurable parameter. At the least we should not duplicate the configuration hereaddress
andpartition
are unsigned integers, not strings. Also thepartition
parameter is no longer needed. It should be cleaned up at some point.rising_edge_mask
,falling_edge_mask
, andinvert_edge_mask
are of typeu32
but have a string a defaultdata_source
type should be unsigned integerFakeHSIGenerator
andCTBModule
inherit fromHSIEventSender
, the schema should reflect that