search

DUNE-DAQ / iomanager

Package providing a unified API
0 stars 0 forks source link

Added debug printout to show the server and port #53

Closed bieryAtFnal closed 1 year ago

bieryAtFnal commented 1 year ago

I don't know if this information is available somewhere else, but I found it useful to know what ConnSvc host and port was being used in our Apps. If the info is available elsewhere, we can close this PR. And, I'm explicitly listing the Target Release as 4.1 since this isn't an urgent issue.

eflumerf commented 1 year ago

My only comment would be that it may be better to put it near https://github.com/DUNE-DAQ/iomanager/blob/1d89eb20a3f28b5c294f12c4fbb57cd06d4ee9d5/src/network/NetworkManager.cpp#L76, since that is where the host/port are retrieved from the environment...

bieryAtFnal commented 1 year ago

As suggested, I have moved the printout to the NetworkManager.cpp file...