Open plasorak opened 2 years ago
When running pylint on minidaqapp, one finds the following unused vars:
pylint
minidaqapp
> pylint *.py |egrep 'unused-(variable|argument)' dataflow_gen.py:56:17: W0613: Unused argument 'RUN_NUMBER' (unused-argument) dataflow_gen.py:58:17: W0613: Unused argument 'SYSTEM_TYPE' (unused-argument) dataflow_gen.py:59:17: W0613: Unused argument 'SOFTWARE_TPG_ENABLED' (unused-argument) dqm_gen.py:38:17: W0613: Unused argument 'EMULATOR_MODE' (unused-argument) dqm_gen.py:39:17: W0613: Unused argument 'RUN_NUMBER' (unused-argument) dqm_gen.py:40:17: W0613: Unused argument 'DATA_FILE' (unused-argument) dqm_gen.py:44:17: W0613: Unused argument 'DQM_ENABLED' (unused-argument) dqm_gen.py:54:8: W0612: Unused variable 'cmd_data' (unused-variable) dqm_gen.py:56:8: W0612: Unused variable 'required_eps' (unused-variable) fake_hsi_gen.py:51:17: W0613: Unused argument 'HSI_DEVICE_ID' (unused-argument) fake_hsi_gen.py:59:8: W0612: Unused variable 'required_eps' (unused-variable) hsi_gen.py:58:17: W0613: Unused argument 'RUN_NUMBER' (unused-argument) hsi_gen.py:60:17: W0613: Unused argument 'TRIGGER_RATE_HZ' (unused-argument) hsi_gen.py:87:8: W0612: Unused variable 'hsi_controller_init_data' (unused-variable) mdapp_multiru_gen.py:101:122: W0613: Unused argument 'host_timing_hw' (unused-argument) mdapp_multiru_gen.py:101:157: W0613: Unused argument 'timing_hw_connections_file' (unused-argument) mdapp_multiru_gen.py:102:8: W0613: Unused argument 'hsi_device_name' (unused-argument) mdapp_multiru_gen.py:102:25: W0613: Unused argument 'hsi_readout_period' (unused-argument) mdapp_multiru_gen.py:102:45: W0613: Unused argument 'hsi_endpoint_address' (unused-argument) mdapp_multiru_gen.py:102:67: W0613: Unused argument 'hsi_endpoint_partition' (unused-argument) mdapp_multiru_gen.py:102:91: W0613: Unused argument 'hsi_re_mask' (unused-argument) mdapp_multiru_gen.py:102:104: W0613: Unused argument 'hsi_fe_mask' (unused-argument) mdapp_multiru_gen.py:102:117: W0613: Unused argument 'hsi_inv_mask' (unused-argument) mdapp_multiru_gen.py:102:131: W0613: Unused argument 'hsi_source' (unused-argument) mdapp_multiru_gen.py:231:8: W0612: Unused variable 'nw' (unused-variable) mdapp_multiru_gen.py:330:4: W0612: Unused variable 'mgraphs_readout' (unused-variable) readout_gen.py:59:17: W0613: Unused argument 'RUN_NUMBER' (unused-argument) readout_gen.py:75:8: W0612: Unused variable 'NUMBER_OF_DATA_PRODUCERS' (unused-variable) readout_gen.py:76:8: W0612: Unused variable 'cmd_data' (unused-variable) readout_gen.py:78:8: W0612: Unused variable 'required_eps' (unused-variable) readout_gen.py:82:8: W0612: Unused variable 'RATE_KHZ' (unused-variable) thi_gen.py:53:17: W0613: Unused argument 'RUN_NUMBER' (unused-argument) thi_gen.py:61:17: W0613: Unused argument 'PARTITION' (unused-argument) thi_gen.py:76:8: W0612: Unused variable 'thi_init_data' (unused-variable) trigger_gen.py:67:17: W0613: Unused argument 'SYSTEM_TYPE' (unused-argument)
This PR fixes some of it. I didn't want to touch the THI, DQM and (Fake-)HSI apps because Stoyan and Juan Miguel are working on it; so maybe we can wait until they finish and merge their changes, and have another pass at this afterwards.
When running
pylint
onminidaqapp
, one finds the following unused vars:This PR fixes some of it. I didn't want to touch the THI, DQM and (Fake-)HSI apps because Stoyan and Juan Miguel are working on it; so maybe we can wait until they finish and merge their changes, and have another pass at this afterwards.