search

DUNE-DAQ / minidaqapp

0 stars 1 forks source link

scalable queue size wrt link numbers #27

Closed mroda88 closed 3 years ago

mroda88 commented 3 years ago

This pull request extends the MPMC queue as a function of the number of links. I don't know if we have to do the same trick with the queue for the time sync. Feedback and opinions are welcome here especially before merging. I tested this configuration and indeed it makes things stable at 50 Hz :-)

roland-sipos commented 3 years ago

Interesting. Could/Should we somehow capture some monitoring data when the MPMC out actually chokes up? (To see the effect.) And I'm not sure it makes a big difference for the timesync, as it runs on a quite low rate.

bieryAtFnal commented 3 years ago

This looks good to me. I copied the logic to the nanorc/rudf_gen.py file, since that file seemed analogous to fake_app_confgen.py.

mroda88 commented 3 years ago

Sorry, I could not add a proper approval because it was I that opened the pull request, so I could not review it. But we decided it was complete in a meeting with Kurt and Giovanna