search

DUNE-DAQ / minidaqapp

0 stars 1 forks source link

Feature/hsi hw readout #51

Closed strilov closed 3 years ago

strilov commented 3 years ago

Thanks a lot Kurt. Yes, it's certainly possible to run with real HSI hardware. I'll put some instructions together, and let you know.

strilov commented 3 years ago

Hi Kurt. I've put together some instructions here on configuring and reading out HSI hardware. If you have a chance, please feel free to try them out (you'll need the latest develop of timing, timinglibs, as well as the latest from this branch).

We can discuss more tomorrow.

bieryAtFnal commented 3 years ago

Hi Stoyan, thanks for the instructions and the note that let me know about them.

I added a short comment to those instructions to hopefully raise awareness that different versions of readout and trigger are needed for the HSI-related work than what is described on the v2.6 software area instructions. I also added a post to the np04-daq-integration Slack channel to try to explain what is going on. I hope that my comments help people, rather than make things more confusing. In any case, I haven't yet managed to try a real-HSI test cause I was messing around with builds.

strilov commented 3 years ago

Thanks @bieryAtFnal. I can redo tests from the demo earlier. Apart from that, do we want to do any other tests?

bieryAtFnal commented 3 years ago

No, I think that if you feel that the merged script looks good, then we're good to go.

I looked at your additions to the CLI help, and those look good. I appreciate the change to make --fake-hsi default True.

strilov commented 3 years ago

No problem. I've actually just pushed another commit, to make the flag more explicit (it still defaults to fake HSI).

If you are happy with the last commit, I think we can merge. I've verified that the earlier test with real HSI still works.

bieryAtFnal commented 3 years ago

Could we change the Default for the hw vs. fake option to specify "fake" somehow?

The existing default text of "false" is a little hard to know what that means...

  --hw-hsi / --fake-hsi           Flag to control whether fake or real
                                  hardware HSI config is generated  [default:
                                  False]

Thanks!

strilov commented 3 years ago

How about something like below?

@click.option('--use-hsi-hw', default=False, help='Flag to control whether fake or real hardware HSI config is generated. Default is fake')

That way it's more consistent with the --use-felix flag.

bieryAtFnal commented 3 years ago

Sure, that would be OK

strilov commented 3 years ago

OK, done.