DUNE-DAQ / minidaqapp

0 stars 1 forks source link

Documentation updates to provide instructions on configuration options for Minidaq app #59

Closed carloschavez closed 3 years ago

carloschavez commented 3 years ago

Documentation updates to provide instructions on configuration options for Minidaq app using nanorc.

shows examples on how to run different configurations using nanorc on minidaq app.

jcfreeman2 commented 3 years ago

A definite improvement.

bieryAtFnal commented 3 years ago

I realize that this Pull Request has already been closed, but I'm going to add some notes to it, in the hope that GitHub will send an email with the contents of this comment.

First off, sorry for not looking at the changes sooner; they look like a good start. And, apologies if you've already started on some of the changes that I mention below.

Some comments:

Thanks, Kurt

carloschavez commented 3 years ago

Hi Kurt,

Thanks very much for your input, I agree with your points, as you said, this is by no means finished. I will implement more changes in a new pull request.

Thanks, Carlos

carloschavez commented 3 years ago

I have now Implemented the changes requested by Kurt, will request a new PR.