search

DUNE-DAQ / minidaqapp

0 stars 1 forks source link

Feature/timing rc integration #71

Closed strilov closed 3 years ago

bieryAtFnal commented 3 years ago

I ran some quick tests in which I focused on existing functionality. That is, I tried to verify that the changes on this branch don't noticeably affect the usual operation of the system. I ran 'integration' tests with 1) basic functionality, 2) with SWTPG enabled, and 3) with DQM enabled (but no graphical viewer).

Things looked good from those tests, but I was mainly focused on the writing of the data as the measure of success.

One note: before I ran my tests, I merged the current contents of the develop branch in minidaqapp into the _timing_rcintegration branch (so that I was testing as much as possible). I did not push those changes to the central repository, but I can do that on Friday. Or, someone else could do those merges (there weren't any conflicts reported by git.)

strilov commented 3 years ago

Hi Kurt. If existing functionality isn't broken, then we can probably go ahead. On my side, I tested the new functionality, and things appeared to be working.

Please go ahead, and push your develop merge.

bieryAtFnal commented 3 years ago

Done (merge from develop into this branch...)