Interrupt start/stop if the run registry insertion failed

DUNE-DAQ / nanorc

2 stars 2 forks source link

Interrupt start/stop if the run registry insertion failed #242

Closed plasorak closed 4 months ago

plasorak commented 4 months ago

Corresponding issue: https://github.com/DUNE-DAQ/ehn1-operations-issues/issues/12

To test (and don't do that too many times, because this creates a run without run registry entry)

usual pip install -e . of nanorc on this branch.
in nanorc/src/nanorc/conf_data/run_registry.json, modify the address to be gibberish.
try to start a run without the --ignore-run-registry-insertion-error flag.
stop should fail too without that flag.

wesketchum commented 4 months ago

Works at NP04 with nano04rc (or at least does no harm).

@plasorak , as I see it default is for 'False' (do not ignore) everywhere. I don't know if we wanted nanorc to default to true to preserve behavior or not. nano04rc defaulting false is perfect.