Making some changes to do with daq-kube

TiagoTAlves commented 9 months ago

So far I have added some directories that get created with

make create-pocketdune-cluster

to the .gitignore file.

Also when committing some changes to daq-kube, realised that daq-kube was being cloned by https not ssh. (Not sure if this was intentional or not)

TiagoTAlves commented 9 months ago

After speaking to @plasorak he said that cloning using https was intentional and so I changed it back

jcpunk commented 9 months ago

Can you squash down to one commit?

On Wed, Nov 15, 2023, 11:45 AM Tiago Alves @.***> wrote:

@.**** commented on this pull request.

In .makefile/daq-kube.mk https://github.com/DUNE-DAQ/pocket/pull/116#discussion_r1394546784:

@@ -1,3 +1,3 @@ ${MAKEFILE_DIR}/daq-kube/.kluctl.yaml: @echo "Fetching daq-kube repo..."

@cd ${MAKEFILE_DIR} && git clone https://github.com/DUNE-DAQ/daq-kube.git --recursive

@cd ${MAKEFILE_DIR} && git clone https://github.com/DUNE-DAQ/daq-kube.git --recursive

The space was a mistake after changing back from @.*** Back to https... I have now removed the space

— Reply to this email directly, view it on GitHub https://github.com/DUNE-DAQ/pocket/pull/116#discussion_r1394546784, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2673TYA3R7QU7DIEJ3PE3YET5SPAVCNFSM6AAAAAA7CZPVVGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMZSGYYDKNJSHA . You are receiving this because your review was requested.Message ID: @.***>

DUNE-DAQ / pocket

Making some changes to do with daq-kube #116

@.**** commented on this pull request.