DUNE-DAQ / readout

This package contains Upstream DAQ Readout specific software and utilities, appfwk DAQModules, CCM interface implementations, and software emulators.
2 stars 1 forks source link

Added TLOG messages to DataLinkHandler for do_start and do_stop #118

Closed bieryAtFnal closed 3 years ago

bieryAtFnal commented 3 years ago

This is fairly minor, but I often find it helpful to have messages in our daq_application log files that indicate when a given run starts and stops.

This PR adds such messages to the DataLinkHandler plugin. My assumption is that there will always be at least one DLH in each Readout App, so adding these messages to the DLH code will be sufficient. I used the same pattern for these messages as what we've done in other places (e.g. dfmodules/plugins/DataWriter.cpp).

roland-sipos commented 3 years ago

Does this mean that the dependencies of readout need to include also rcif? (So the CMake files need to be extended also?) If so, that's perfectly fine. After the reorganization of readout after v2.8, only the modules will rely on rcif, not the core readout infrastructure and packages.

bieryAtFnal commented 3 years ago

Ah, good question. I was expecting that rcif would be brought in automatically by the use of appfwk (which has an explicit find_package(rcif) in its CMakeLists.txt). I'm not sure that I know the rigorously correct answer. I only know that it currently works without an explicit find_package(rcif) in the readout CMakeLists.txt. I will ask our SW Coordination colleagues.

roland-sipos commented 3 years ago

Then it's perfectly fine. After the restructuring we might add explicit find_package calls in the upcoming romodules package.