DUNE-DAQ / readoutmodules

0 stars 0 forks source link

Add CPU pinning module #4

Closed philiprodrigues closed 2 years ago

philiprodrigues commented 2 years ago

This PR adds a DAQModule that pins threads to CPU cores based on the configuration it's given. This is intended as a short-term solution for v2.10.2 and the spring 2022 VD coldbox tests - how to deal with this issue in the longer term is up for discussion.

philiprodrigues commented 2 years ago

For anyone reading this in future, Roland and I just discussed the implementation. Roland is right that if all the threads are created at conf, then looping in CPUPinner::do_work shouldn't be needed. But I think the induction hit-finding thread is created at start (in another module), so we will keep CPUPinner::do_work as it is for now.

alessandrothea commented 2 years ago

Please remember that the agreement for the foreseeable future is that the Pinning will be done via scripting and, as long as that is the case, the pinning via Modules will not be allowed to avoid confusion.