Closed dianaAntic closed 4 months ago
Are these changes planned for a fddaq-v4.4.x patch release? If so, then the target merge branch for this PR needs to be changed...
Are these changes planned for a fddaq-v4.4.x patch release? If so, then the target merge branch for this PR needs to be changed...
Are these changes planned for a fddaq-v4.4.x patch release? If so, then the target merge branch for this PR needs to be changed...
Yes the goal is to get these in for the patch release, thank you for the comment, I will change the target branch!
This PR adds the ability to send periodic commands in the
nanotimingrc
session which would typically require usingdtsbutler
commands. To test that these changes don't break anything, I ran thedaqconf_timing_gen
command to generate a configuration folder containing:boot.json
,conf.json
,data/
, among other files, as well as the new:master_send_periodic_command_sends.json
which contains:Then, I started a
nanotimingrc
session using the following cmd:nanotimingrc --partition-number 2 conf/ test-sess
where theconf/
folder is the aforementioned generated folder.