search

DUNE-DAQ / trigemu

Trigger decision emulator for January 2020 readout application tests
0 stars 0 forks source link

DUNE Linter Cleanup #33

Closed eflumerf closed 3 years ago

eflumerf commented 3 years ago 
sourcecode/trigemu/include/trigemu/Issues.hpp:0:  No #ifndef header guard found, suggested CPP variable is: TRIGEMU_INCLUDE_TRIGEMU_ISSUES_HPP_  [build/header_guard] [5]
sourcecode/trigemu/include/trigemu/Issues.hpp:0:  The standard copyright message wasn't found.  [legal/copyright] [5]
sourcecode/trigemu/include/trigemu/Issues.hpp:8:  An unsigned integer appears to be used here.  [build/unsigned] [3]
sourcecode/trigemu/include/trigemu/Issues.hpp:9:  Namespace should be terminated with '// namespace dunedaq  '  [readability/namespace] [5]
sourcecode/trigemu/plugins/FakeTimeSyncSource.cpp:78:  An unsigned integer appears to be used here.  [build/unsigned] [3]
sourcecode/trigemu/plugins/FakeTimeSyncSource.hpp:47:  An unsigned integer appears to be used here.  [build/unsigned] [3]
sourcecode/trigemu/plugins/FakeTimeSyncSource.hpp:52:  #endif line should be "#endif  // TRIGEMU_PLUGINS_FAKETIMESYNCSOURCE_HPP_"  [build/header_guard] [5]
sourcecode/trigemu/plugins/FakeTimeSyncSource.hpp:8:  #ifndef header guard has wrong style, please use: TRIGEMU_PLUGINS_FAKETIMESYNCSOURCE_HPP_  [build/header_guard] [5]
sourcecode/trigemu/plugins/TriggerDecisionEmulator.hpp:153:  An unsigned integer appears to be used here.  [build/unsigned] [3]
sourcecode/trigemu/plugins/TriggerDecisionEmulator.hpp:154:  An unsigned integer appears to be used here.  [build/unsigned] [3]
sourcecode/trigemu/plugins/TriggerDecisionEmulator.hpp:155:  An unsigned integer appears to be used here.  [build/unsigned] [3]
sourcecode/trigemu/plugins/TriggerDecisionEmulator.hpp:156:  An unsigned integer appears to be used here.  [build/unsigned] [3]
sourcecode/trigemu/src/TimestampEstimator.cpp:0:  The standard copyright message wasn't found.  [legal/copyright] [5]
sourcecode/trigemu/src/TimestampEstimator.cpp:11:  An unsigned integer appears to be used here.  [build/unsigned] [3]
sourcecode/trigemu/src/TimestampEstimator.cpp:26:  Add #include <memory> for unique_ptr<>  [build/include_what_you_use] [4]
sourcecode/trigemu/src/TimestampEstimator.cpp:95:  Namespace should be terminated with '// namespace dunedaq::trigemu  '  [readability/namespace] [5]
sourcecode/trigemu/src/trigemu/TimestampEstimator.hpp:23:7: warning: class 'TimestampEstimator' defines a non-default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions]
sourcecode/trigemu/src/trigemu/TimestampEstimator.hpp:23:7: warning: class 'TimestampEstimator' defines a non-default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions]
sourcecode/trigemu/src/trigemu/TimestampEstimator.hpp:27:  An unsigned integer appears to be used here.  [build/unsigned] [3]
sourcecode/trigemu/src/trigemu/TimestampEstimator.hpp:34:  Add #include <memory> for unique_ptr<>  [build/include_what_you_use] [4]
sourcecode/trigemu/test/plugins/FakeTokenGenerator.cpp:88:  Add #include <utility> for move  [build/include_what_you_use] [4]
sourcecode/trigemu/test/plugins/FakeTokenGenerator.hpp:54:  #endif line should be "#endif  // TRIGEMU_TEST_PLUGINS_FAKETOKENGENERATOR_HPP_"  [build/header_guard] [5]
sourcecode/trigemu/test/plugins/FakeTokenGenerator.hpp:8:  #ifndef header guard has wrong style, please use: TRIGEMU_TEST_PLUGINS_FAKETOKENGENERATOR_HPP_  [build/header_guard] [5]