DUNE / ND_CAFMaker

Code for making CAFs from ND inputs (whether 2x2+MINERvA prototype or full ND simulation)
Apache License 2.0
1 stars 11 forks source link

Eliminate truth-matching hacks #28

Closed chenel closed 10 months ago

chenel commented 11 months ago

As of PicoRun4, vertexIDs are no longer rewritten to be consecutive, and the 2x2-MLReco pipeline is fully propagating vertexIDs through it, so we no longer need the workarounds that we previously needed. Remove them here.

This comes with some new code to match run and vertexID numbers and updates to the storage classes that hold onto the GENIE tree(s) once loaded.

I also snuck in a few small updates (bypassing the GENIE splash screen, fixing a 'deprecated method' warning from FHICL).

This PR depends on some others that are used in the input file preparation: https://github.com/DeepLearnPhysics/larcv2/pull/43 https://github.com/DeepLearnPhysics/SuperaAtomic/pull/17 https://github.com/DeepLearnPhysics/larnd2supera/pull/3

chenel commented 10 months ago

Verified that this actually works on PicoRun4.1 files. The larnd2supera PR listed above hasn't yet been merged, but we're going to merge to flow2supera very soon anyways, and the same commits will need to be ported there instead...