search

DUNE / dune-tms

DUNE ND Temporary Muon Spectrometer
0 stars 1 forks source link

Fixed overlay issue by moving hits outside event.Primary loop. Added … #24

Closed jdkio closed 1 year ago

jdkio commented 1 year ago

…reco effects section. Also saving timing info for tracks

LiamOS commented 1 year ago

Agree with Lukas regarding the large commented blocks, although at least one of them was there previously, so I guess there's some spring cleaning for me to do.

Content looks fine by-eye though. Will run a few quick tests tomorrow before merging, need to recompile some dependencies.

jdkio commented 1 year ago

Thanks for the suggestions. I removed all the comment blocks I could find.

LiamOS commented 1 year ago

Apologies for the delay. I just saw that in the "saving checkpoint" commit you've added a 30MB binary file src/stbdA9YY. Is this a mistake, or does this file serve a purpose? I'll just remove if it's unimportant.

jdkio commented 1 year ago

Yeah that's an error. I'm not sure how that happened. You can remove it. Thanks

ast0815 commented 1 year ago

It would be better to rebase so that file is not part of the commit history at all. Otherwise it will still get downloaded with every "clone". Though it does not matter if you use "squash" to merge everything in the end and then delete this branch.

jdkio commented 1 year ago

I removed src/stbdA9YY via rebase.

LiamOS commented 1 year ago

Squashed and merged, apologies for the delay!