search

DUNE / dune-tms

DUNE ND Temporary Muon Spectrometer
0 stars 1 forks source link

TMS Bar FindModules bugfix #27

Closed jdkio closed 1 year ago

jdkio commented 1 year ago

In testing Tejin's file ConvertToTMSTree.exe /dune/app/users/tejinc/DUNESoftware/ND/work/edep_files/larsoft_edep_dump_tms_merged.root the code got stuck in an infinite loop. Turns out it's because the hit was from a geometry node above volDetEnclosure. So the nodes travel up to volWorld and then gets stuck in an infinite loop there. This bugfix prevents that.

jdkio commented 1 year ago

I'm not sure why the timing commits made it in. It's supposed to only be the last commit.

LiamOS commented 1 year ago

Would it be possible to submit another request with only the correct commit? I don't think I'm able to remove them with the web interface.

ast0815 commented 1 year ago

You can rebase and force-push on this PR. No need for a new one.

jdkio commented 1 year ago

I made things much worse by trying to rebase. I need to figure this out, sorry