search

DUNE / dune-tms

DUNE ND Temporary Muon Spectrometer
0 stars 1 forks source link

Swapped -999...s for #defined constants, including NaNs #92

Open LiamOS opened 5 months ago

LiamOS commented 5 months ago

Based on some Slack chatter I swapped out most of the -999...s for __TMS_BAD_NUMBER__ = -99999999 if it's an int, and with a NaN defined as __TMS_NAN__ for any doubles. I haven't properly tested this, hence the draft. Need to check that the timeslicing or other output isn't affected (other than some out-of-range values changing around).

jdkio commented 5 months ago

I am a little worried about NaNs. Sometimes they aren't handeled well, and you may not notice the misbehavior if you're not looking for it. Like if you have a cut for a != b, then it always evaluates to true if a or b is NaN. Personally, sticking to -999999999 makes sense and is less likely to cause issues