DUNE / dune-tms

DUNE ND Temporary Muon Spectrometer
0 stars 1 forks source link

Feature/zpos sort instead of plane number #97

Closed LiamOS closed 5 months ago

LiamOS commented 5 months ago

This PR is pretty basic. Currently TMS_Hits are sorted with various Sort() methods defined in TMS_Hit.h, which use the PlaneNumber to sort stuff. For the base geometry this is fine, but Magnus' geometries have common plane numbers in a way that breaks the sorting.

I've marked this as a draft for now, as this doesn't need committing just yet, and I want to run it by both of you so we can understand if we should just do it this way in general now, or have both ways (z pos and plane number) for use.

Edit: May also be possible to do this by sorting the TMS_KalmanNode objects, as they have a < and > defined using the z position taken from TMS_Bar