search

DUNE / dunedataprep

Apache License 2.0
0 stars 7 forks source link

Raw data dists not filled for HD coldbox data #7

Closed dladams closed 2 years ago

dladams commented 2 years ago

I wanted to check raw ADC distributions for the recent HD cold box data but found the distributions are not filled for the the induction channels.

dladams commented 2 years ago

I suspect problem is that distributions are only filled if the flag is set to good and somwhere there is check that the ADC count is less that 4096 as would be true for 14 bit ADCs but the new data is 16 bit.

I wanted to check this with AdcDataDumper but it does not display flags--only raw and prepared data. I am adding the flag capability there.

dladams commented 2 years ago

AdcDataDumper now has the option to show flags and has LogLevel.

dladams commented 2 years ago

However i see that the flags are all 0 in hdcoldbox and so that is not the problem.

Looking at the code for AdcChannelPlotter, I see that it starts by making hists over the range (0, 4096]. I changed that to (0, 4*4096] and now I see distributions for all channels.

dladams commented 2 years ago

Build tests passed and mods are committed.