search

DUNE / dunesw

Apache License 2.0
4 stars 26 forks source link

PDVD fix cosmics simulation window #113

Closed YoannKermaidic closed 5 months ago

YoannKermaidic commented 5 months ago

The cosmics generator sample time remained set to 4 ms while the readout window is currently 3 ms. This generates lots of logs from PDS simulation due to photons generated after the 3 ms window:

%MSG-w WaveformDigitizerSim:  WaveformDigitizerSim:opdigi@BeginModule  06-Mar-2024 18:15:43 CET run: 1 subRun: 0 event: 1
Skipping a photon at 3798.43 us, outside digitization window of -3005 to 3005
%MSG

This is fixed at generator configuration level by setting:

physics.producers.cosmicgenerator.SampleTime: 6.0e-3
physics.producers.cosmicgenerator.TimeOffset: -3.0e-3

instead of 

physics.producers.cosmicgenerator.SampleTime: 8.0e-3
physics.producers.cosmicgenerator.TimeOffset: -4.0e-3

In addition, I remove the temporary g4 stage2 fix, I added some time ago to solve a breaking of the sim/reco chain, for deposits that happened outside the active volume.

wenqiang-gu commented 5 months ago

@YoannKermaidic The changes work well for me. For the production, should we still use the fhicls below?

protodunevd_refactored_g4_stage2_pureAr.fcl
protodunevd_refactored_detsim_pureAr.fcl
YoannKermaidic commented 5 months ago

@wenqiang-gu Yes, we should because they enable the PDS simulation. The other "default" ones are charge only.