search

DUNE / dunesw

Apache License 2.0
4 stars 27 forks source link

CRP6 TPC+PDS reconstruction #127

Closed YoannKermaidic closed 1 month ago

YoannKermaidic commented 4 months ago

Added PDS analysis to default CRP6 TPC reconstruction:

YoannKermaidic commented 4 months ago

Raw PDS waveforms deconvolution not yet well setup. !! To be fixed before merging !!

tomjunk commented 4 months ago

What's the status here? I see the comment

Raw PDS waveforms deconvolution not yet well setup. !! To be fixed before merging !!

and two commits five minutes later. Converting to draft.

YoannKermaidic commented 3 months ago

Hi Tom,

Still working on that (see progress here: https://indico.fnal.gov/event/65511/). I want to try to have the T0 matching implemented before a merge

tomjunk commented 2 months ago

Hi Yoann -- still working? Incidentally, on Tingjun's request, I added to the PD-SP PDS decoder the creation of a raw::RDTimeStamp (header in lardataobj) for each OpDetWaveform and associated it with the OpDetWaveform. The issue is that OpDetWaveform has a double precision timestamp whose comment says microseconds since 1970, and a double precision number only has 14 bits of precision while there are more than 1.6E15 microseconds since January 1, 1970. So a uint64 (ROOT's ULong64_t) is a better way of storing a timestamp. Might this help you too? Affects the data decoding.

aolivier23 commented 1 month ago

@YoannKermaidic any updates here? I'm cutting a release this Friday and would be happy to review some code if this is ready.

YoannKermaidic commented 1 month ago

Hi @aolivier23 , Let me upload the latest version of my development code that is stable now. Then we can merge afterwards

YoannKermaidic commented 1 month ago

Ready for merge

aolivier23 commented 1 month ago

trigger build with dune/dunesw#127

FNALbuild commented 1 month ago

:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild commented 1 month ago

:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild commented 1 month ago

:x: CI build for DUNE Failed at phase build DUNE on slf7 for c14:prof -- details available through the CI dashboard

:rotating_light: For more details about the failed phase, check the build DUNE phase logs

parent CI build details are available through the CI dashboard

FNALbuild commented 1 month ago

:x: CI build for DUNE Failed at phase build DUNE on slf7 for e26:prof -- details available through the CI dashboard

:rotating_light: For more details about the failed phase, check the build DUNE phase logs

parent CI build details are available through the CI dashboard