search

DUNE / dunesw

Apache License 2.0
4 stars 27 forks source link

Adding fcls for CAFMaker #128

Closed pgranger23 closed 4 months ago

pgranger23 commented 4 months ago

Adding several fcls files to run the FD CAFMaker module. Energy and angle reconstruction are recomputed to allow for an easy integration of reco improvements.

pgranger23 commented 4 months ago

Hi Dominic, Indeed, these algorithms are already run as part of reco2. However, they have been subject to several improvements lately, and I felt like re-running them right before producing the CAFs would allow for the integration of the latest modifications (moreover, the processing time of these steps is relatively small). I guess this might lead to some "reproducibility" issues, but at least on the atmospherics side, I think this is relevant to rerun these algorithms during the CAF production.

absolution1 commented 4 months ago

Hi Pierre. OK I see what you mean. Just to double check, the energy reco has had one change since the last production run, right?

If the only change to the energy reco is to force MCS or ranging then I agree with rerunning. However, I don't think that the standard fcls should rerun the energy/angular reco. I know this is a pain, but could you add in one more set of fcls that inherits from the standard fcls and also reruns the energy/angular reco (and take those reprocessings out of the standard fcls)?

pgranger23 commented 4 months ago

Ok. So for now I think this is the only change. However Henrique has made some improvements lately in the energy reco that he expects to be able to present soon. Sure, additional fcls seems to be a solution to fulfill all needs, I'll try to add them ASAP. Do you have any naming suggestions for those?

absolution1 commented 4 months ago

Ok. So for now I think this is the only change. However Henrique has made some improvements lately in the energy reco that he expects to be able to present soon. Sure, additional fcls seems to be a solution to fulfill all needs, I'll try to add them ASAP. Do you have any naming suggestions for those?

Sounds good. For the naming, something like: cafmaker_atmos_dune10kt_1x2x6_runreco-nuenergy-nuangular.fcl No option is going to be particularly pretty but I think the main things are to 1) drop 'standard' 2) some kind of identifier at the end of the fcl

pgranger23 commented 4 months ago

Should be done by now. I tested part of the fcls and they seem correct.

pgranger23 commented 4 months ago

I think (hope) I addressed all the comments. I moved the energyreco config in https://github.com/DUNE/dunereco/pull/107 , and this PR now depends on this dunereco one.

tomjunk commented 4 months ago

I merged the dunereco one and will get this one in this week's release.