tomjunk
commented
3 months ago What's the status here? Should this go in? Looks like develop is slowly diverging but easily enough fixable.
Open mantheys opened 7 months ago
tomjunk
commented
3 months ago What's the status here? Should this go in? Looks like develop is slowly diverging but easily enough fixable.
lpaulucc
commented
3 months ago @tomjunk we should hear from Sergio but we won't need this PR for the LE prod, at least not for the first phase.
mantheys
commented
2 months ago Hi!
I agree with Laura, no need to include this for production. This PR is already a bit old, so I should better double-check that everithing is up to date.
Sergio
De: Laura Paulucci @.***> Enviado: jueves, 20 de junio de 2024 23:56:08 Para: DUNE/dunesw Cc: Manthey Corchado, Sergio; Mention Asunto: Re: [DUNE/dunesw] Solar dunesw (PR #99)
@tomjunkhttps://urldefense.com/v3/__https://github.com/tomjunk__;!!D9dNQwwGXtA!TmfFdWiR6QBnrDo3kNlfDPOizdDIrcqK37e92V6L87W2TkU8nj4_I8fhm_9VksxpcjDq_urM8fBLDhiP1_2AzaC47u1myw$ we should hear from Sergio but we won't need this PR for the LE prod, at least not for the first phase.
— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/DUNE/dunesw/pull/99*issuecomment-2181622823__;Iw!!D9dNQwwGXtA!TmfFdWiR6QBnrDo3kNlfDPOizdDIrcqK37e92V6L87W2TkU8nj4_I8fhm_9VksxpcjDq_urM8fBLDhiP1_2AzaCXQOrGbQ$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AQWSF5HLNLN7FYVASPBF2Y3ZINFXRAVCNFSM6AAAAABJUVLTQWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBRGYZDEOBSGM__;!!D9dNQwwGXtA!TmfFdWiR6QBnrDo3kNlfDPOizdDIrcqK37e92V6L87W2TkU8nj4_I8fhm_9VksxpcjDq_urM8fBLDhiP1_2AzaAOiWDI1A$. You are receiving this because you were mentioned.Message ID: @.***>
Small naming & structure changes for consistency with VD workflow.