DUNE / larnd-sim

Simulation framework for a pixelated Liquid Argon TPC
Apache License 2.0
10 stars 26 forks source link

Feature/ajw minirun5 fix #191

Closed AWh1t3 closed 6 months ago

AWh1t3 commented 6 months ago

Removes double digitization of noise padding at front and back of light waveforms.

AWh1t3 commented 5 months ago

lines 587, 597, and 605 accept padding for the noise waveforms multiplied by four in generate_light_noise(): noise in the signal portion has been multiplied by four already in simulate_pixels.py line 1022, so the entire 1000 ticks are then divided by and re-multiplied by four in light_sim.py line 621.

krwood commented 5 months ago

who reviewed this PR anyway?! ;)