search

DUNE / larnd-sim

Simulation framework for a pixelated Liquid Argon TPC
Apache License 2.0
10 stars 29 forks source link

Feature seg truth hotfix #225

Closed YifanC closed 6 months ago

YifanC commented 6 months ago

@mjkramer @krwood As Matt suggested, I added comments on why we need the hotfix and why it is a hotfix. It is a fairly isolated change. all_mod_tracks are passed in the module loop as tracks which have the truth information updated, but not all_mod_tracks, we are patching all_mod_tracks here because the unsolved flow issue. The code is tested to a degree that it verifies the output contains the updated segments.

YifanC commented 6 months ago

Oh btw I updated the Git Issue #216 @krwood

YifanC commented 6 months ago

I will begrudgingly approve the PR, but I’m still not comfortable with the way the code is laid out. Specific to this PR, I really don’t think it’s great that we simulate the quenching and drifting on one segment dataset, and then simulate the pixel responses, and then re-simulate the quenching and drifting in another segment dataset for “back tracking”. We should backtrack to the exact input to the pixel response simulation (especially with the outstanding reproducibility issues). I wouldn’t be surprised if we find the backtracking bugs you and Kazu are encountering in the ml reco training work are related to this.

Relate this comment to Kevin's Git Issue #228