DUNE / larnd-sim

Simulation framework for a pixelated Liquid Argon TPC
Apache License 2.0
10 stars 26 forks source link

Readability of larndsim #227

Open YifanC opened 2 months ago

YifanC commented 2 months ago

I think one of the reason larndsim readability is low is that when we define intermediate data, we uses shape of previous intermediate data, for example here (instead of using len(unique_pix), we use pixels_signals.shape[0])

Suggestions:

  1. Add comments
  2. Explicitly define the intermediate data type
  3. Enforce consistency check