fix bug in trigger timestamp when not using light sim

DUNE / larnd-sim

Simulation framework for a pixelated Liquid Argon TPC

Apache License 2.0

10 stars 29 forks source link

fix bug in trigger timestamp when not using light sim #94

Closed AlexWilkinsonnn closed 2 years ago

AlexWilkinsonnn commented 2 years ago

I was calculating z from the times and associated trigger times and noticed that the trigger times are much larger than the data packet timestamps. I think the code that makes the trigger packets expects a time relative to the event start time but was getting an absolute time for when the light sim is turned off. Let me know if I've misunderstood something.

Alex

soleti commented 2 years ago

@peter-madigan do you think it's fine to merge this? Unfortunately it looks like I can't add you as a reviewer, not sure why, maybe you're not part of the DUNE GitHub organization

peter-madigan commented 2 years ago

Yep looks good to me. Do you know who to contact to get added to the dune GitHub org?

soleti commented 2 years ago

@peter-madigan I think the person is @brettviren